envoyproxy / envoyproxy/nighthawk
Coverage: ensure we hit the case where the warmup request fails.
Open
good first issue
help wanted
tech-debt
- Dominant language
- C++
- Stars
- 414
- Forks
- 95
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 11
Description
Just observed that this line isn't always hit, and caused a dip under the coverage threshold in CI:
https://3858-180498819-gh.circle-artifacts.com/0/coverage/coverage/proc/self/cwd/source/client/client_worker_impl.cc.html#L38
We should add a dedicated test to ensure we hit it.
Contributor guide
Assessment
This issue has not been assessed yet.