envoyproxy / envoyproxy/nighthawk
coverage_integration test binary size too large after protobuf update to v23.1
- Dominant language
- C++
- Stars
- 414
- Forks
- 95
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 11
Description
coverage_integration test binary size increase after protobuf update to v23.1
*Description*:
The coverage_integration stage test binary fails to link due to size increase post Envoy commit to https://github.com/envoyproxy/envoy/pull/28075. Linker options in the envoy_binary macro need to added to workaround the linker issue, similar to the workaround used in the envoy_test macro https://github.com/envoyproxy/envoy/blob/ad3c1c8519d73ef9f746a570a96ab4c0dd7fa907/bazel/envoy_test.bzl#L58.
*Reproduction steps*:
Sync your local branch to Envoy https://github.com/envoyproxy/envoy/pull/28075. Run the coverage_integration test locally, RBE or in CI.
Running `ci/do_ci.sh coverage_integration` will execute in RBE if it is set up, otherwise it run locally.
To execute locally run the command directly:
https://github.com/envoyproxy/nighthawk/blob/9fd10eb1f90f3f342771cba09041ab63fdd7263a/test/run_nighthawk_bazel_coverage.sh#L37
*Logs*:
https://dev.azure.com/cncf/envoy/_build/results?buildId=142266&view=results
ld.lld: error: /opt/llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a(InstrProfilingPlatformLinux.c.o):(function __llvm_write_binary_ids: .text.__llvm_write_binary_ids+0x15): relocation R_X86_64_PC32 out of range: -2149800033 is not in [-2147483648, 2147483647]; references __ehdr_start
>>> referenced by InstrProfilingPlatformLinux.c
ld.lld: error: /opt/llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a(InstrProfilingPlatformLinux.c.o):(function __llvm_write_binary_ids: .text.__llvm_write_binary_ids+0x25): relocation R_X86_64_PC32 out of range: -2149800105 is not in [-2147483648, 2147483647]; references __ehdr_start
>>> referenced by InstrProfilingPlatformLinux.c
ld.lld: error: /opt/llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a(InstrProfilingPlatformLinux.c.o):(function __llvm_write_binary_ids: .text.__llvm_write_binary_ids+0x2c): relocation R_X86_64_PC32 out of range: -2149800080 is not in [-2147483648, 2147483647]; references __ehdr_start
>>> referenced by InstrProfilingPlatformLinux.c
ld.lld: error: /opt/llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a(InstrProfilingPlatformLinux.c.o):(function __llvm_write_binary_ids: .text.__llvm_write_binary_ids+0xb4): relocation R_X86_64_PC32 out of range: -2149800248 is not in [-2147483648, 2147483647]; references __ehdr_start
>>> referenced by InstrProfilingPlatformLinux.c
ld.lld: error: /opt/llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a(InstrProfilingPlatformLinux.c.o):(function __llvm_write_binary_ids: .text.__llvm_write_binary_ids+0x25a): relocation R_X86_64_PC32 out of range: -2149800670 is not in [-2147483648, 2147483647]; references __ehdr_start
>>> referenced by InstrProfilingPlatformLinux.c
Contributor guide
Assessment
This issue has not been assessed yet.