envoyproxy / envoyproxy/java-control-plane
lose watch when SimpleCache respond return false in respondWithSpecificOrder
Open
- Dominant language
- Java
- Stars
- 312
- Forks
- 149
- PR merge metrics
- No merged PRs in 30d
Description
For ADS mode, class io.envoyproxy.controlplane.cache.SimpleCache will respond to client when setSnapshot.
When respond(watch, snapshot, group); return false, respondWithSpecificOrder will lose the watch, since respond is not complete, client will not rewatch
`
respond(watch, snapshot, group);
// Discard the watch. A new watch will be created for future snapshots once envoy ACKs the response.
return true;
`
Contributor guide
Assessment
This issue has not been assessed yet.