envoyproxy / envoyproxy/gateway

Improved global rate limiting metric keys

Open
#9,151 2 comments 2 reactions 0 assignees View on GitHub
help wanted kind/enhancement
Dominant language
Go
Stars
3k
Forks
864
Avg merge
2d 2h
Merged PRs (30d)
140

Description

*Description*:
Currently global rate limit keys look like the following
`envoy-gateway-system/gateway/rule/0_gateway/gateway/rule/0`

it would be nice if we could have a easier way to identify which rule this is as position 0 in array is not very useful. This also means dashboards/alerts that use this key may break if the ordering changes.

I suggest we introduce maybe a name key? So we at least can add this to the end for example

`envoy-gateway-system/gateway/rule/0_gateway/gateway/rule/0/basic-limit`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.