envoyproxy / envoyproxy/gateway
Helm chart `nameOverride` of Deployment/Service/ConfigMap/ServiceAccount, etc.
- Dominant language
- Go
- Stars
- 3k
- Forks
- 864
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 140
Description
The chart already implements the standard `nameOverride` and `fullnameOverride` [helpers](https://github.com/envoyproxy/gateway/blob/ebf33a572e0f6b64f4565063181f1055219da985/charts/gateway-helm/templates/_helpers.tpl#L1-L24) and also uses `{{ include "eg.fullname" . }}` to name _some_ resources (for example all RBAC, the certgen and the topology injector components). However the _"primary"_ resources like the Deployment, Service, ConfigMap, ServiceAccount, etc. are hardcoded to be named `envoy-gateway`. So it's a bit inconsistent and I'd like the ability to override the names of these resources too.
If we are to align with how most other charts do it, we would basically:
```diff
apiVersion: apps/v1
kind: Deployment
metadata:
- name: envoy-gateway
+ name: {{ include "eg.fullname" . }}
namespace: '{{ .Release.Namespace }}'
```
```diff
apiVersion: v1
kind: ConfigMap
metadata:
- name: envoy-gateway-config
+ name: {{ include "eg.fullname" . }}-config
namespace: '{{ .Release.Namespace }}'
```
I can submit a PR for this, if you're open to the idea!
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.