envoyproxy / envoyproxy/gateway

Refactor error interface in gatewayapi status pkg

Open
#7,958 1 comment 0 reactions 1 assignee Claimed by @kkk777-7 View on GitHub
area/translator stale
Dominant language
Go
Stars
3k
Forks
864
Avg merge
2d 2h
Merged PRs (30d)
140

Description

*Description*:
>Describe the issue.

currently, we have `Error` interface in gatewayapi status pkg to handle error conditions.
https://github.com/envoyproxy/gateway/blob/main/internal/gatewayapi/status/error.go#L107-L111

this interface methods expects that method's return value is RouteCondition.

we also want to handle listener conditions. so, we should use generics to avoid duplication codes.

[optional *Relevant Links*:]
>Any extra documentation required to understand the issue.

original comment: https://github.com/envoyproxy/gateway/pull/7909/files#r2678298973

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.