envoyproxy / envoyproxy/gateway

Revert quoted value zone annotation in topology injector

Open
#7,492 5 comments 0 reactions 0 assignees View on GitHub
stale triage
Dominant language
Go
Stars
3k
Forks
864
Avg merge
2d 2h
Merged PRs (30d)
140

Description

*Description*:
https://github.com/envoyproxy/gateway/pull/6133 double quotes the zone annotation within the topology injector. This is incorrect, as the value of `ENVOY_SERVICE_ZONE` now contains double quotes (e.g., `topology.kubernetes.io/zone: test` returns `ENVOY_SERVICE_ZONE="\"test\""`. Although there was a small discussion within the PR for this issue, my opinion is that a fix was applied for envoy-gateway when it's an issue with their cloud provider.

https://github.com/envoyproxy/gateway/pull/6133#issuecomment-2902873654

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.