envoyproxy / envoyproxy/gateway

Unexpected service selector update after update of labels for envoy pods

Open
#7,309 12 comments 3 reactions 0 assignees View on GitHub
area/api area/infra-mgr
Dominant language
Go
Stars
3k
Forks
864
Avg merge
2d 2h
Merged PRs (30d)
140

Description

*Description*:
When labels defined in [EnvoyProxy resource for envoy pods](https://gateway.envoyproxy.io/docs/api/extension_types/#kubernetespodspec), they also updated in kubernetes [Service](https://kubernetes.io/docs/concepts/services-networking/service/) selector. This behavior cause downtime when any labels added or changed for envoy pods in `EnvoyProxy` resource, because selector in service updates instantly, but update of `Deployment` require time for rollout update.

*Repro steps*:
1. Add label for envoy pod in `EnvoyProxy`;
2. Notice change in `Service` selector;

*Environment*:
It's reproducible on 1.5.4, but I believe it's introduced earlier

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.