envoyproxy / envoyproxy/gateway

Use Patch instead of Update to update Resource Status

Open
#6,946 1 comment 0 reactions 0 assignees View on GitHub
provider/kubernetes stale
Dominant language
Go
Stars
3k
Forks
864
Avg merge
1d 22h
Merged PRs (30d)
148

Description

> @BadLiveware are you seeing this error `unable to update status`
> https://github.com/envoyproxy/gateway/blob/da0d9134642b74e3c757bf1c09f7cc25e7efbd89/internal/provider/kubernetes/status_updater.go#L118C19-L118C42
>
> or this metric `status_update_total` bump with `failure` label ?
>
> Also noticing that we are using Update instead of Patch here which needs be fixed, creating a new issue for it

_Originally posted by @arkodg in [#6898](https://github.com/envoyproxy/gateway/issues/6898#issuecomment-3282921097)_

Here's the code https://github.com/envoyproxy/gateway/blob/da0d9134642b74e3c757bf1c09f7cc25e7efbd89/internal/provider/kubernetes/status_updater.go#L116

There are multiple issues with Update https://github.com/kubernetes-sigs/gateway-api/issues/1629

Here's an example of using Patch https://github.com/envoyproxy/gateway/blob/bb3f4bae5049a5431f143b1862f0e60c300a901c/internal/infrastructure/kubernetes/infra_client.go#L28

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.