envoyproxy / envoyproxy/gateway

Should EG skip publishing for non-retriable errors at the provider layer, as well as errors from the Gatway API translator or the xDS translator?

Open
#6,448 3 comments 0 reactions 0 assignees View on GitHub
kind/decision provider/kubernetes stale
Dominant language
Go
Stars
3k
Forks
864
Avg merge
2d 2h
Merged PRs (30d)
140

Description

the goal of the provider layer is to an accurate snapshot of the resources, the only reason it may be unable to do so is because of any faulty I/O, in that case we skip a `publish` . In the future we can improve this to skip public per GC, which is a bigger design change

_Originally posted by @arkodg in https://github.com/envoyproxy/gateway/pull/6299#discussion_r2176251276_

Also mentioned in this comment from @guydc https://github.com/envoyproxy/gateway/pull/6299#issuecomment-2984867601

Notes from the community meeting:

- Provider layer should publish an accurate state-of-the-world.
- If transient errors make it impossible to build an accurate snapshot, the reconciliation should be retried by returning early with an error
- If validation errors are encountered, state should be published, so that status can be updated and user notified about issues with resources.
- If users want to implement alternative strategies for handling invalid configuration (e.g. pausing XDS updates), that should be implemented in other layers.
-

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.