envoyproxy / envoyproxy/gateway
Understanding Which ratelimit Package to Use
Open
stale
- Dominant language
- Go
- Stars
- 3k
- Forks
- 864
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 140
Description
*Description*: Currently, 'internal/xds/translator/ratelimit.go' utilizes 'github.com/envoyproxy/go-control-plane/ratelimit/config/ratelimit/v3'. 'ratelimit.RateLimitConfig' does not have the ValidateAll() function, as a result, we cannot validate the resource. We need to understand why we don't use 'github.com/envoyproxy/go-control-plane/envoy/config/ratelimit/v3'.
[optional *Relevant Links*:] You may find more context at https://github.com/envoyproxy/gateway/pull/1662#discussion_r1280927756
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.