envoyproxy / envoyproxy/envoy

SSL Connection: combine SSL_set_ex_data and SSL_set_app_data

Open
#9,867 2 comments 0 reactions 1 assignee Claimed by @jimini-lumox View on GitHub
area/tls help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Title*: *Combine SSL Connection's SSL_set_ex_data and SSL_set_app_data*

*Description*:
PR #9172 introduces additional SSL_set_ex_data to be able to update SslExtendedSocketInfo during SSL validation.
This issue is to refactor the new SSL_set_ex_data and existing SSL_set_app_data to combine to a single SSL_set_app_data.

Currently:
SSL_set_app_data: The ContextImpl's `const Network::TransportSocketOptions*` options set by the ContextImpl but only if (options && !options->verifySubjectAltNameListOverride().empty()) when the SslSocket is created
SSL_set_ex_data: The SslSocketInfo::SslExtendedSocketInfo member set when the SslSocket is subsequently moved to be owned by the constructed SslSocketInfo

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.