envoyproxy / envoyproxy/envoy

CacheFilter: Parse and handle precondition request headers

Open
#9,855 2 comments 0 reactions 0 assignees View on GitHub
area/cache help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

CacheFilter (#7198) must fully parse and handle precondition request headers [(RFC7232):](https://httpwg.org/specs/rfc7232.html) if-match, if-none-match, if-modified-since, if-unmodified-since, and if-range.

This must be fixed before CacheFilter can be appropriate for production deployment.

We currently ignore these headers, which is incorrect, and will result in serving wrong content from cache. As a temporary shortcut, it would be acceptable to instead bypass caching for requests with precondition header. This would reduce cache effectiveness and give clients an easy way to bypass cache, but would never cause incorrect results. With the shortcut, this issue would no longer block production deployment of CacheFilter.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.