envoyproxy / envoyproxy/envoy

Envoy should register invalid HTTP as an attempt to send a request

Open
#9,821 4 comments 0 reactions 0 assignees View on GitHub
area/http help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: Envoy should register invalid HTTP as an attempt to send a request

*Description*:
If a malformed HTTP1 request is sent (e.g. No headers, just "a\r\n\r\n") the HTTP1.1 code will reject it (https://github.com/envoyproxy/envoy/blob/master/source/common/http/http1/codec_impl.cc#L497) and send a 400 without creating a ConnectionManagerImpl::ActiveStream. This means that the stats around total requests (downstream_rq_total_ & similar) will not be modified, as they are modified by ConnectionManagerImpl::ActiveStream. It seems like an invalid request should still be counted in those statistics.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.