envoyproxy / envoyproxy/envoy

Protecting envoy from stacking events on the same fd

Open
#8,925 3 comments 0 reactions 0 assignees View on GitHub
help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Description*:
The way envoy FileEventImpl use libevent is tricky. If two FileEventImpl refer to the same fd, eventually the assigned events are stacked
and it's probably hard to recover the intention of each other.

https://github.com/envoyproxy/envoy/pull/8922 is the one I encountered but I believe there are more hidden.

We need to figure out
1. what is pattern we should follow all over envoy,
2. how to detect the violation
3. what are the tools to debug when we suspect there is violation

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.