envoyproxy / envoyproxy/envoy

adaptive concurrency: Allow specification of runtime names

Open
#8,638 0 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

As a prerequisite to supporting both egress and ingress adaptive concurrency, it will be necessary to specify the runtime configuration names to avoid conflicts. Before declaring the filter production ready, the adaptive concurrency configuration parameters should be replaced by their runtime counterparts.

To be more specific for anyone who gets to this before I do, we want to change any parameters in the [adaptive_concurrency.proto](https://github.com/envoyproxy/envoy/blob/999c27b905d41b402bf505244dbde6bfdf224636/api/envoy/config/filter/http/adaptive_concurrency/v2alpha/adaptive_concurrency.proto) that correspond to any of the [runtime options ](https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/adaptive_concurrency_filter#runtime)that override them. For example, changing parameters in the proto from [Uint32](https://github.com/envoyproxy/envoy/blob/master/api/envoy/config/filter/http/adaptive_concurrency/v2alpha/adaptive_concurrency.proto#L51) to [RuntimeUInt32](https://github.com/envoyproxy/envoy/blob/ad57b58cfbb256af41a467260dce2a8013b7a7fa/api/envoy/api/v2/core/base.proto#L145).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.