envoyproxy / envoyproxy/envoy

Avoid using HeaderMapImpl for gRPC metadata

Open
#7,921 1 comment 0 reactions 0 assignees View on GitHub
area/security bug help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

Today, we use `HeaderMapImpl` for gRPC metadata, e.g. https://github.com/envoyproxy/envoy/blob/3dd84d3b41b6be378ccb71e81c0063a84bb956e3/include/envoy/grpc/async_client.h#L70. This is not safe, since in general, this metadata may contain binary and `HeaderMapImpl` can't contain NUL.

We should switch to using a simple map or the like to model these values, treating them as metadata rather than headers.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.