envoyproxy / envoyproxy/envoy

Add annotations for certificates listed in /certs

Open
#7,604 6 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Title*: Add annotations for certificates listed in /certs

*Description*:
Per discussion with @PiotrSikora and @incfly on https://github.com/envoyproxy/envoy/issues/7111#issuecomment-499291659, we need to add annotations or something similar into /certs dump to clearly display the type of each certificate, i.e., certificates from static secret, inline secret or SDS. It would be nice if we can add SDS resource name and other information into the annotation, so that we can associate certificates from /certs to SecretConfig(PR https://github.com/envoyproxy/envoy/pull/7365) dump from /config_dump while debugging SDS related issues.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.