envoyproxy / envoyproxy/envoy

grpc keepalive/h2 ping support for upstream

Open
#7,136 3 comments 0 reactions 0 assignees View on GitHub
area/grpc enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

gPRC currently uses h2 pings to check the channel health status. As per the gRPC docs, this needs to be enabled on both gRPC server and the client. The default for GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS is false, which means if the client tries to send h2 pings, server will reset the connection.

#2086 mentions that envoy will revert back to any downstream h2 pings, which seems like a sensible flow. What the envoy docs fail to mention is how envoy configures these gRPC pings and what are the current values.

Is GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS true by default ?
Would envoy further perform any h2 ping checks on upstream if it receives a downstream ping ?
How are half closed connections/streams handled (closed from upstream end) ?

Also, there are other parameters that are supported in core gRPC implementation (GRPC_ARG_HTTP2_MAX_PING_STRIKES etc), should these be configurable in envoy config ? as it acts as a gRPC server while proxying.

https://github.com/grpc/grpc/blob/master/doc/keepalive.md

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.