envoyproxy / envoyproxy/envoy

Allow option to not emit statsd metrics when reporting a `0` value

Open
#6,205 4 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

We store the statsd metrics envoy emits in a SAAS monitoring tool that charges us based on the number of measurements we store at a particular reporting interval. Some of the metrics we are recording are consistently `0`, with occasional spikes when something happens. Here's an example:

![image 2019-03-07 at 11 54 16 am](https://user-images.githubusercontent.com/20394/53955018-c2ac7200-40cf-11e9-8e81-e98d616a4484.png)

I can see the value in using a 0 value to report "nothing is happening", but our monitoring bill has doubled as a result of adopting envoy(!), and continues to grow as we add more clusters, so we'd like to save some money by not recording measurements we can mostly infer from an absence of data.

That said, the zero values were very helpful when were spiking into adopting envoy, as it allowed us to see which metrics we could expect from envoy. Maybe this should be a configuration option in the [`StatsMatcher` proto](https://www.envoyproxy.io/docs/envoy/latest/api-v2/config/metrics/v2/stats.proto#config-metrics-v2-statsmatcher)?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.