envoyproxy / envoyproxy/envoy

HDS should't initialize HdsCluster hosts as FAILED_ACTIVE_HC

Open
#5,408 5 comments 0 reactions 0 assignees View on GitHub
area/hds enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Title*: *HDS should't initialize HdsCluster hosts as FAILED_ACTIVE_HC*

*Description*:
HDS should't initialize HdsCluster hosts as FAILED_ACTIVE_HC, because when we may use hds as a **`heartbeat reporting channel`** with only endpoints and no health checks as follows:
```
cluster_health_checks {
cluster_name: "user"
locality_endpoints {
endpoints {
address {
socket_address {
address: "172.16.0.1"
port_value: 8080
}
}
}
}
}
interval {
seconds: 5
}
```

we should chanage the initializing as follows:
```
void HdsCluster::initialize(std::function callback) {
initialization_complete_callback_ = callback;
//for (const auto& host : *initial_hosts_) {
// host->healthFlagSet(Host::HealthFlag::FAILED_ACTIVE_HC);
//}

auto& first_host_set = priority_set_.getOrCreateHostSet(0);
auto healthy = createHealthyHostList(*initial_hosts_);

first_host_set.updateHosts(initial_hosts_, healthy, HostsPerLocalityImpl::empty(),
HostsPerLocalityImpl::empty(), {}, *initial_hosts_, {}, absl::nullopt);
}
```
related to issue: #1845

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.