envoyproxy / envoyproxy/envoy

reverse_tunnel: Implement proactive pings from the downstream_socket_interface

Open
#46,677 1 comment 0 reactions 1 assignee Claimed by @aakugan View on GitHub
area/reverse_tunnels enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Title*: reverse_tunnel: Implement proactive pings from the downstream_socket_interface

*Description*:
Currently the downstream_socket_interface does not proactive ping the upstream side using the RPING mechanism -> it only responds to pings this makes the downstream side invisible to reachability.
Worse if the network falls through the downstream never detects it while the upstream thinks the connection is gone. This could have prevented issues like [this](https://github.com/envoyproxy/envoy/pull/46556).
Expectation here is to implement http2 style ping and pong frames and have keepalive duration and timeout before the socket is upgraded to http2 for such detections from both ends.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.