envoyproxy / envoyproxy/envoy

Clean up tests that start an admin HTTP server just to get by

Open
#4,531 0 comments 0 reactions 0 assignees View on GitHub
help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

After #4486 is submitted, it will be possible to create an instance of the Admin admin console class without automatically starting an HTTP listener. Tests that specify an admin address in a bootstrap config - and so start an HTTP listener - just to get through startup correctly can now have that listening address removed. At least one example (I think?) is in test/config/utility.cc, ConfigHelper constructor.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.