envoyproxy / envoyproxy/envoy

Re-enable GeoIP filter for configs testing

Open
#42,486 1 comment 1 reaction 1 assignee Claimed by @agrawroh View on GitHub
area/envoy-filter-example no stalebot tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

## Description

We ended up excluding the GeoIP filter i.e. `root/configuration/http/http_filters/_include/geoip-filter.yaml` config as part of the examples build as it was crashing. We suspected that the `example_configs_test` is using mock environments that probably don't support the filesystem watchers and background threads.

The GeoIP provider creates a dedicated thread for watching MaxMind's DB file changes and the crash seems to be happening when the GeoIP provider is trying to create its background file-watcher thread.

This issue is to track the fix for `example_configs_test` and remove it from the exclusion list once we get it to work.

cc @phlax

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.