envoyproxy / envoyproxy/envoy

Leaky internal engine in mobile

Open
#41,342 4 comments 0 reactions 0 assignees View on GitHub
bug mobile no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

While working on #41149 , I discovered that `InternalEngine*` is saved as a raw pointer. This creates a leak which is manually suppressed with `absl::LeakIgnore`. I have tried using `unique_ptr` first, but that causes strange issues:
* mobile coverage fails with a mystery heap-use-after-free;
* Swift tests flake.

This should probably be addressed at some point with more robust lifetime.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.