envoyproxy / envoyproxy/envoy

Add trace/span attributes for internal error status and latency crossing the Envoy layer

Open
#40,042 1 comment 0 reactions 0 assignees View on GitHub
area/tracing enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: *Add trace/span attributes for _internal_ error status and latency crossing the Envoy layer*

*Description*:

I'm working with a team at my org who's trying to prove to skeptical internal dev groups that Envoy is faster than older proxy setups. We've had good success showing off performance improvements by tracing other tools. We'd like to have span attributes in Envoy that show the time it took for Envoy to process a request internally, and another attribute to record if there's an error internal to Envoy. That would let us track Envoy's impact on performance and errors in our tracing systems.

*Relevant Links*:

We've enabled `spawn_upstream_span` as documented [here](https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto#envoy-v3-api-field-extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-tracing-spawn-upstream-span), but tis still only shows key attributes like `duration_ms` in relation to the proxied call. We don't see a separate span attribute that shows _internal_ latency within Envoy itself.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.