envoyproxy / envoyproxy/envoy

fine grained dependency beween the api proto

Open
#39,692 6 comments 0 reactions 1 assignee Claimed by @wbpcode View on GitHub
api enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Title*: *fine grained dependency beween the api proto*

Now in our proto API, every bazel package only contains one build target. That means all these dependencis are using the package as the basic unit.

That make it's easy to result in cycle dependency and we have encountered related problem. For example, the TypedExtensionConfig in the StringMatcher. When we want to TypedExtensionConfig to the StringMatcher, because the `envoy/config/core/v3` have depended the `envoy/type/matcher/v3`, we cannot use config.core.v3.TypedExtensionConfig in the matcher package and finally the TypedExtensionConfig in the cncf/xds is used. (Of course, specific to the TypedExtensionConfig, cncf/xds may be an acceptable option, but this example is enough to elucidate the problem.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.