envoyproxy / envoyproxy/envoy

Change QuicHttpIntegrationTest to use TestUsingSimulatedTime

Open
#38,875 2 comments 0 reactions 1 assignee Claimed by @danzh2010 View on GitHub
area/test flakes no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

`QuicHttpIntegrationTest` sometimes flakes, especially lately in the [AsyncCertVerificationAfterDisconnect](https://github.com/envoyproxy/envoy/blob/90068a6eb1739ffcef555f793cce27220ab43120/test/integration/quic_http_integration_test.cc#L725) and [AsyncCertVerificationAfterTearDown](https://github.com/envoyproxy/envoy/blob/90068a6eb1739ffcef555f793cce27220ab43120/test/integration/quic_http_integration_test.cc#L768) tests, which depend on timing of the QUIC disconnects and completion of cert verification.

We've addressed the issue by adjusting the timeouts: https://github.com/envoyproxy/envoy/pull/38864

However, a better long term solution would be to use a simulated time system for the test: [TestUsingSimulatedTime](https://github.com/envoyproxy/envoy/blob/a8f78e6c120decd989477a215350a6c419c2fb55/test/test_common/simulated_time_system.h#L133)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.