envoyproxy / envoyproxy/envoy

Add filter_enabled flag to RBAC filter

Open
#38,435 4 comments 2 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Title*: Add filter_enabled flag to RBAC filter

*Description*:
Currently, [Envoy's RBAC filter](https://github.com/envoyproxy/envoy/blob/0bf518c005dc2372e40ee79e9f22fefb07abe29a/api/envoy/extensions/filters/http/local_ratelimit/v3/local_rate_limit.proto#L61) does not have a `filter_enabled` field that other http filters have (e.g. [localRateLimit](https://github.com/envoyproxy/envoy/blob/0bf518c005dc2372e40ee79e9f22fefb07abe29a/api/envoy/extensions/filters/http/local_ratelimit/v3/local_rate_limit.proto#L61) and [extAuth](https://github.com/envoyproxy/envoy/blob/0bf518c005dc2372e40ee79e9f22fefb07abe29a/api/envoy/extensions/filters/http/ext_authz/v3/ext_authz.proto#L158)). Adding this flag to the RBAC filter would provide flexibility in enabling or disabling the filter at runtime based on runtime settings allowing for dynamic management of filter behavior without requiring a full configuration deployment.

I can prepare a patch for this if it sounds reasonable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.