envoyproxy / envoyproxy/envoy

use rq_total in load_stats_reporter to tell whether there is load

Open
#37,115 3 comments 0 reactions 0 assignees View on GitHub
area/load reporting enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Title*: use rq_total in load_stats_reporter to tell whether there is load

*Description*:
In load_stats_reporter.cc, Envoy use rq_active+rq_success+rq_error to tell whether there is load for a cluster locality.

See https://github.com/envoyproxy/envoy/pull/37083, in some rare cases, rq_total is a better indicator for load: no matter a response is received or not, a request is "handled"(activeStream, cluster picking, host picking, connection creation) by Envoy already.

We should just use rq_total to indicate whether there is load.

https://github.com/envoyproxy/envoy/blob/3a1a72e9d7a272e452bb5499c4dcdc43e1eee5ed/source/common/upstream/load_stats_reporter.cc#L106

[optional *Relevant Links*:]
>related total_issued introduced in https://github.com/envoyproxy/envoy/pull/6784

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.