envoyproxy / envoyproxy/envoy

problem of current edge request and internal request determination

Open
#36,971 5 comments 0 reactions 0 assignees View on GitHub
area/connection area/http no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Title*: *problem of exist edge request and internal request determination*

*Description*:

This is a feature has almost same lifetime with the Envoy self. But I think there are some problem in this feature:

1. A request will be determined as edge request only when the `use_remote_address` is enabled. But today, the `original_ip_detection_extensions` may be used as alternative of `use_remote_address`.
2. If there are multiple hop proxies and `use_remote_address` is used, the requests will always be treated as external requests except in the first hop.
3. If `use_remote_address` is used in a inner proxy, some requests may be determined as edge request incorrectly.

[optional *Relevant Links*:]
>Any extra documentation required to understand the issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.