envoyproxy / envoyproxy/envoy

config validation: validator only checks for file presence not content

Open
#36,289 0 comments 0 reactions 0 assignees View on GitHub
area/config_validation help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

when file system is used to configure Envoy, the config validator (`-mode validate`) only checks if files are present but does not load those files to check if their content is valid.

In this super simple config:
```
dynamic_resources:
cds_config:
resource_api_version: V3
path_config_source:
path: /test/cds.yaml
lds_config:
resource_api_version: V3
path_config_source:
path: /test/lds.yaml
```

the validator will accept empty and non-yaml files when run in `validate` mode.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.