envoyproxy / envoyproxy/envoy

After cluster NACK, reconnection never requests CDS again

Open
#34,334 11 comments 0 reactions 1 assignee Claimed by @keithmattix View on GitHub
area/xds bug no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Title*: After cluster NACK, reconnection never requests CDS again

*Description*:
Originally reported to Istio in: https://github.com/istio/istio/issues/50670.

What we are seeing is a sequence:
* Initial state: proxy is connected, with CDS/LDS/EDS/RDS/SDS over Delta XDS
* Send an update with an invalid cluster.
* Disconnect from control plane (GOAWAY)
* On reconnect, CDS is never requested (EDS->LDS->RDS is)

*Repro steps*:
https://github.com/istio/istio/issues/50670 has steps with Istio. I tried to reproduce locally with go-control-plane and was unable to for some reason

*Logs*:
[istiod.txt](https://github.com/envoyproxy/envoy/files/15425803/istiod.txt)
[envoy.txt](https://github.com/envoyproxy/envoy/files/15425804/envoy.txt)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.