envoyproxy / envoyproxy/envoy

Support envoy.service.discovery.v3.ResourceName in response resources.

Open
#34,285 14 comments 0 reactions 0 assignees View on GitHub
area/xds beginner enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

Title: Support `envoy.service.discovery.v3.ResourceName` in response resources.

Description: [envoy.service.discovery.v3.Resource](https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/discovery/v3/discovery.proto#service-discovery-v3-resource) definition has either `name` or `resource_name` field to distinguish it from other resources of the same type. [envoy.service.discovery.v3.ResourceName](https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/discovery/v3/discovery.proto#envoy-v3-api-msg-service-discovery-v3-resourcename) is designed to allow multiple variants of the named resource that are differentiated by dynamic parameter constraints. Currently this is not supported by Envoy - it will reject response resources with ResourceName.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.