envoyproxy / envoyproxy/envoy

mobile: Add support for multi-engine in AndroidNetworkMonitor

Open
#33,351 1 comment 0 reactions 0 assignees View on GitHub
enhancement mobile no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: *Add support for multi-engine in AndroidNetworkMonitor for Envoy Mobile*

*Description*:
[AndroidNetworkMonitor](https://github.com/envoyproxy/envoy/blob/4dd1ef272f6cfc863be440ee5f3a2c37375ee521/mobile/library/java/io/envoyproxy/envoymobile/engine/AndroidNetworkMonitor.java) does not support multi-engine given that it is holding on a single [EnvoyEngine](https://github.com/envoyproxy/envoy/blob/4dd1ef272f6cfc863be440ee5f3a2c37375ee521/mobile/library/java/io/envoyproxy/envoymobile/engine/AndroidNetworkMonitor.java#L40) instance via a singleton pattern.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.