envoyproxy / envoyproxy/envoy

Overload manager action to fail readiness check

Open
#33,168 5 comments 0 reactions 0 assignees View on GitHub
area/overload_manager enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

The recommendation in https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#best-practices-edge for configuring an overload manager looks like so:

```
- name: "envoy.overload_actions.shrink_heap"
triggers:
- name: "envoy.resource_monitors.fixed_heap"
threshold:
value: 0.95
- name: "envoy.overload_actions.stop_accepting_requests"
triggers:
- name: "envoy.resource_monitors.fixed_heap"
threshold:
value: 0.98
```

For folks who are running envoy in a cloud native environment, would it not be better to provide an action that will start failing the healtcheck, so the `/ready` endpoint starts failing? In this scenario, traffic won't be sent to the pod until the service is healthy again.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.