envoyproxy / envoyproxy/envoy

mobile/test: Have the iOS and Android integration tests send requests to a locally spun up Envoy instead of external websites

Open
#32,553 0 comments 0 reactions 1 assignee Claimed by @abeyad View on GitHub
enhancement mobile no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

A lot of our Android and iOS mobile integration tests send requests to an external website like example.com.
We shouldn't do this - it makes for non-hermetic tests and is not good for the external website to get such traffic.

For most of the integration tests, we can create a local Envoy test server, but for some of them that create an Envoy test server for other purposes (xDS, proxy support), we will have to change the test infra b/c the Envoy test server can only be a singleton right now

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.