envoyproxy / envoyproxy/envoy

admin: making a streaming version of /config_dump

Open
#32,054 3 comments 0 reactions 0 assignees View on GitHub
area/admin area/perf enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

/config_dump can produce a remarkably huge response. This will need to be fully buffered both as a protobuf message and an in-memory continuous string. For large configs, this will be slow and may exert memory pressure as well.

See also #31755 as well as prior work streaming admin stats in https://github.com/envoyproxy/envoy/pull/19693. This work is not trivial and has risks. See also the difficult attempt to make /stats/prometheus stream as well: https://github.com/envoyproxy/envoy/pull/24998 which needed to be rolled back due to complexities in the Prom format that made streaming difficult. See also https://github.com/envoyproxy/envoy/pull/28988 which adds a streaming json serializer, which probably should be used for this, rather than creating a protobuf structure and then serializing that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.