envoyproxy / envoyproxy/envoy

move Golang extension from contrib to standard

Open
#31,685 12 comments 11 reactions 0 assignees View on GitHub
area/contrib area/extension area/golang no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

### Motivation
Make people use the standard version with confidence.
Some people have expressed concerns about the contrib version, i.e. [the thread in enovy-go slack channel](https://envoyproxy.slack.com/archives/C04QNSXC7U0/p1701921159504429).

### Status
The latest envoy 1.28.0 should be stable enough.
All knowned bug are fixed in envoy 1.28.0. And no new bugs reported since 1.28.0.

Nearly ~100 improvements, and ~5 bugfixes since first merged in contrib.
i.e. retired the `GODEBUG=cgocheck=0` env requirement.

### Test

- [x] fuzzer: https://github.com/envoyproxy/envoy/pull/25884
- [ ] test coverage
- [x] test flake: https://github.com/envoyproxy/envoy/issues/31654

### Doc

There are some baisc doc about how to develop and build plugin, and examples for how to implement golang plugins.

- [ ] need more detailed doc about the Go APIs, for implementing Golang plugins.

### Question
In addition to these TODOs, what else needs to address? Or, any other requirements?
cc @mattklein123 @alyssawilk @phlax @wbpcode Any advice & guidance? Thanks very much!

Maybe it could be done in the 1.31 release? if there are no big blocking issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.