envoyproxy / envoyproxy/envoy

Api: Move geoip_headers_to_add from provider level to geoip filter

Open
#31,001 0 comments 0 reactions 0 assignees View on GitHub
area/geoip area/http_filter enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Title*: *Move geoip_headers_to_add from provider level to geoip filter*

*Description*:
Currently [geoip_headers_to_add](https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/geoip_providers/common/v3/common.proto#extensions-geoip-providers-common-v3-commongeoipproviderconfig-geolocationheaderstoadd) are configured in geoip provider. From logical standpoint it makes more sense to have them in geoip filter [config](https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/geoip_providers/common/v3/common.proto#extensions-geoip-providers-common-v3-commongeoipproviderconfig-geolocationheaderstoadd) instead, as this is not property of provider (from which source the data is being looked up) but filter (what kind of data to get from provider).

*Relevant Links*
[Discussion](https://github.com/envoyproxy/envoy/pull/28490#discussion_r1346411286) in past PR

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.