envoyproxy / envoyproxy/envoy

Adding an API proto file, file gets deleted by `proto_format`

Open
#29,433 2 comments 2 reactions 1 assignee Claimed by @phlax View on GitHub
area/build bug linting no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

Following the instructions from [STYLE.md](https://sourcegraph.com/github.com/envoyproxy/envoy/-/blob/api/STYLE.md), step 4 suggests your new file will be automatically included in `api/versioning/BUILD`, but in fact, with the current implementation, if you don't add it manually, your new file will be deleted by `proto_format.sh fix`

Either the doc should be updated to match reality, or (preferably) the behavior should be updated to match what it used to do with one fewer manual step.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.