envoyproxy / envoyproxy/envoy

Golang network filter missing functions

Open
#29,270 17 comments 0 reactions 0 assignees View on GitHub
area/golang enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

I'm experimenting with the new golang network filter in v1.27.0
and I noticed that native C++ filters are exposed to more functions than what the golang filter is exposing.
for instance, the ConnectionCallback interface: https://github.com/envoyproxy/envoy/blob/f17f1fdd644cc4b32f65579184757e3975843db6/contrib/golang/common/go/api/filter.go#L176-L183
exposes 3 methods,
but from what it looks like the connection callback should have more methods such as `requestedServerName()` to retreive the SNI of the requested server and so on..

so, am I missing something? or is there a plan to add any missing methods to the connection callback later on?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.