envoyproxy / envoyproxy/envoy

Remove tokens from the default bucket only if there is no matching descriptor.

Open
#28,469 2 comments 0 reactions 0 assignees View on GitHub
area/ratelimit help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Title*: *Remove tokens from the default bucket only if there is no matching descriptor.*

*Description*:
I have a question about the Local RateLimit plugin.
In version 1.23.0, the local_ratelimit started removing tokens from all matching buckets, including the default bucket, which now always has a token removed.
Is there a way to prevent this from happening, removing tokens from the default only if there is no matching descriptor?

If there is no way to do this currently, could we make it parameterizable?

Thank you in advance.

[optional *Relevant Links*:]
https://github.com/envoyproxy/envoy/pull/20869

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.