envoyproxy / envoyproxy/envoy

Low coverage in grpc-json transcoder filter

Open
#28,232 0 comments 0 reactions 1 assignee Claimed by @yanavlasov View on GitHub
area/grpc-transcoding bug no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

grpc-json transcoder filter currently has lower than normal coverage due to untested error handling paths.

The prot to JSON formatter in the update protobuf library removed the limitation on the depth of nesting in the Struct proto that can be converted to JSON. A test that validated this case was removed as a result. Unfortunately it was also testing the error handling path on the encoding path, which caused the coverage to dip 93.8%

This issue tracks addition of tests that validate error handling in JSON to proto and proto to JSON transcoding.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.