envoyproxy / envoyproxy/envoy

mobile/iOS: make platform cert validation work when using c++ builder

Open
#26,269 0 comments 0 reactions 1 assignee Claimed by @RyanTheOptimist View on GitHub
enhancement mobile no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Title*: *mobile/iOS: make platform cert validation work with c++ builder*

*Description*:
Platform cert validation works on iOS but only when you use obj-c/Swift engine builder and not the c++ engine builder directly. That's because we perform the registration of platform cert validator inside of `EnvoyEngineImpl` and that class is not used at all when using c++ engine builder directly. https://github.com/envoyproxy/envoy/blob/cea17494ef49969b888368a5fe1709e347acea2e/mobile/library/objective-c/EnvoyEngineImpl.mm#L514

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.