envoyproxy / envoyproxy/envoy

Remove `DELAY` var/functionality from examples/sandboxes `verify.sh`

Open
#26,117 1 comment 0 reactions 1 assignee Claimed by @phlax View on GitHub
area/ci area/examples no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

Adding this was probably the worst design decision when creating the sandboxes - mostly it was added so you could see the proper logs when the sandbox had started 8/

Ideally the compositions use proper health checks and come up by themselves, but where that is not implemented or possible we can use the `wait_for` function to wait until something is ready

Once remaining sandboxes have been purged of this we should remove the functionality altogether

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.