envoyproxy / envoyproxy/envoy

rds template refactor: re-use the code in the config provider

Open
#26,096 3 comments 0 reactions 0 assignees View on GitHub
area/xds enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

We extracted the common part of rds to a template in https://github.com/envoyproxy/envoy/pull/18846. By this way, any proxy could implement it's rds by simple code change.

But I found the code of rds template is similar with the code in the `config/config_provider.h`. I am not sure it's possible to re-use it or merge them. Then we can make the xds-related code more clean and unified.

cc @tkovacs-2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.