envoyproxy / envoyproxy/envoy

CI dependency checker hitting secondary rate limits

Open
#25,929 14 comments 0 reactions 1 assignee Claimed by @phlax View on GitHub
area/ci bug dependencies no stalebot stale
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

This morning the scheduled dependency checker failed hitting a secondary rate limit

https://github.com/envoyproxy/envoy/actions/runs/4341178398/jobs/7580458671#step:4:78

This is ~related to #25742 to the extent that it seems to be an issue with our scheduled action creds

However, in this case, the job _is_ being run with creds (running this target without creds would throw an immediate error).

Im not sure if we are genuinely hitting some rate limit, or as seems more likely, the token creds mean that its not using the authenticated limit when making these queries.

the failing job essentially does 2 things (at least where it has failed) with the github api:

- searches for existing issues matching a spec
- gathers release information about dependencies

we currently have `issues: write` permissions for the job so i think its not failing on the issues search, unless searching is a different permission to r/w

it seems to be failing gathering release info about dependencies. We also run this job in all of our normal CI (ie in AZP) - we have historically had issues with this job but only if it lacked any valid creds - with creds ive never seen it hit any limits

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.