envoyproxy / envoyproxy/envoy

android, c++: add a way to enable proxy support to c++ engine builder

Open
#25,076 2 comments 0 reactions 0 assignees View on GitHub
enhancement mobile no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: *Add a way to enable proxy support to c++ engine builder*

*Description*:
The current implementation for supporting proxies on Android [depends](https://github.com/envoyproxy/envoy/blob/3d88b410b627f0cd6d14a96b3fb74d62747c472a/mobile/library/java/io/envoyproxy/envoymobile/engine/AndroidEngineImpl.java#L26-L28) on `AndroindEngineImpl` being used. That class is not used by `engine_builder.cc` even if it's used on Android platform. Change the setup so that Envoy engines created with the use of `engine_builder.cc` respect system proxy settings.

*Relevant Links*:
https://github.com/envoyproxy/envoy-mobile/issues/2547

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.