envoyproxy / envoyproxy/envoy

Clean up Filesystem abstraction

Open
#24,994 2 comments 0 reactions 1 assignee Claimed by @ravenblackx View on GitHub
bug no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

Sequence of proposed operations.
- [x] Add support for `stat()` to `Filesystem` (including an abstraction wrapper around `struct stat` / `WIN32FINDDATA`)
- [ ] Migrate `Directory()` into `Filesystem` - there is existing Directory() support, but it only works with the real file system, not through the abstraction (meaning no mock, no fake)
- [ ] Migrate `async_file` implementation to using `Filesystem` under the hood, rather than `OsSysCalls`
- [ ] Migrate `file_system_http_cache` implementation to using `Filesystem` rather than a hodgepodge mix of Filesystem, OsSysCalls and Directory()
- [ ] (maybe) Remove from OsSysCalls the functions that are better abstracted through Filesystem.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.